On Mon, Apr 11, 2016 at 5:16 PM, Etsuro Fujita <[email protected]> wrote: > On 2016/04/11 12:30, Michael Paquier wrote: >> >> + if ((cancel = PQgetCancel(entry->conn))) >> + { >> + PQcancel(cancel, errbuf, sizeof(errbuf)); >> + PQfreeCancel(cancel); >> + } >> Wouldn't it be better to issue a WARNING here if PQcancel does not >> succeed? > > Seems like a good idea. Attached is an updated version of the patch.
Thanks for the new version. The patch looks good to me. -- Michael -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
