On Wed, Jul 20, 2016 at 02:12:57PM -0400, Alvaro Herrera wrote: > Michael Paquier wrote: > > On Wed, Jul 6, 2016 at 4:18 PM, Michael Paquier > > <michael.paqu...@gmail.com> wrote: > > > OK, after hacking that for a bit I have finished with option 2 and the > > > set of PG-like set of routines, the use of USE_SSL in the file > > > containing all the SHA functions of OpenBSD has proved to be really > > > ugly, but with a split things are really clear to the eye. The stuff I > > > got builds on OSX, Linux and MSVC. pgcrypto cannot link directly to > > > libpgcommon.a, so I am making it compile directly with the source > > > files, as it is doing on HEAD. > > > > Btw, attached is the patch I did for this part if there is any interest in > > it. > > After quickly eyeballing your patch, I agree with the decision of going > with (2), even if my gut initially told me that (1) would be better > because it'd require less makefile trickery. > > I'm surprised that you say pgcrypto cannot link libpgcommon directly. > Is there some insurmountable problem there? I notice your MSVC patch > uses libpgcommon while the Makefile symlinks the files.
People have, in the past, expressed concerns about linking in pgcrypto. Apparently, in some countries, it's a legal problem. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers