Michael Paquier <michael.paqu...@gmail.com> writes: > On Fri, Jul 22, 2016 at 8:48 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> I'm confused. We need that code in both libpq and backend, no? >> src/common is the place for stuff of that description.
> Not necessarily. src/interfaces/libpq/Makefile uses a set of files > like md5.c which is located in the backend code and directly compiles > libpq.so with them, so one possibility would be to do the same for > sha.c: locate the file in src/backend/libpq/ and then fetch the file > directly when compiling libpq's shared library. Meh. That seems like a hack left over from before we had src/common. Having said that, src/interfaces/libpq/ does have some special requirements, because it needs the code compiled with -fpic (on most hardware), which means it can't just use the client-side libpgcommon.a builds. So maybe it's not worth improving this. > One thing about my current set of patches is that I have begun adding > files from src/common/ to libpq's list of files. As that would be new > I am wondering if I should avoid doing so. Well, it could link source files from there just as easily as from the backend. Not object files, though. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers