On Sat, Aug 20, 2016 at 4:39 AM, Ryan Murphy <ryanfmur...@gmail.com> wrote: > Here is another version of my initdb shell quoting patch. I have removed > the unnecessary {} block. I also ran pgindent on the code prior to creating > the patch.
Could you please *not* top-post? This breaks the logic of the thread, this is the third time that I mention it, and that's not the style of this mailing list. Regarding your patch, with a bit of clean up it gives the attached. You should declare variables at the beginning of a code block or function. One call to appendPQExpBufferStr can as well be avoided, and you added too many newlines. I have switched that as ready for committer. -- Michael
initdb-path-v4.patch
Description: application/download
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers