On Sun, Sep 25, 2016 at 10:30 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Fri, Sep 23, 2016 at 5:34 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: >> >> I think here I am slightly wrong. For the full page writes, it do use >> RBM_ZERO_AND_LOCK mode to read the page and for such mode we are not >> doing page verification check and rather blindly setting the page to >> zero and then overwrites it with full page image. So after my fix, >> you will not see the error of checksum failure. I have a fix ready, >> but still doing some more verification. If everything passes, I will >> share the patch in a day or so. >> > > Attached patch fixes the problem, now we do perform full page writes > for bitmap pages. Apart from that, I have rebased the patch based on > latest concurrent index patch [1]. I have updated the README as well > to reflect the WAL logging related information for different > operations. > > With attached patch, all the review comments or issues found till now > are addressed. >
I forgot to mention that Ashutosh has tested this patch for a day using Jeff's tool and he didn't found any problem. Also, he has found a way to easily reproduce the problem. Ashutosh, can you share your changes to the script using which you have reproduce the problem? -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
