Hello, At Mon, 7 Nov 2016 17:19:29 +0100, Daniel Gustafsson <[email protected]> wrote in <[email protected]> > > On 07 Nov 2016, at 12:32, Daniel Gustafsson <[email protected]> wrote: > > > >> On 04 Nov 2016, at 08:34, Kyotaro HORIGUCHI > >> <[email protected]> wrote: > >> > >> I'm not sure how the discussion about this goes, these patches > >> makes me think about coding style of Perl. > > > > Some of this can absolutely be considered style and more or less down to > > personal preference. I haven’t seen any coding conventions for Perl so I > > assume it’s down to consensus among the committers. > > Actually, scratch that; there is of course a perltidy profile in the pgindent > directory. I should avoid sending email before coffee..
Hmm. Somehow perl-mode on my Emacs is stirring with ununderstandable indentation and I manually correct them so it is highly probable that the style of this patch is not compatible with the defined style. Anyway it is better that pgindent generates smaller patch so I'll try it. regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
