> On 08 Nov 2016, at 17:37, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> > wrote: > > On 10/31/16 12:11 PM, Daniel Gustafsson wrote: >> I took a small stab at doing some cleaning of the Perl scripts, mainly around >> using the more modern (well, modern as in +15 years old) form for open(..), >> avoiding global filehandles for passing scalar references and enforcing use >> strict. Some smaller typos and fixes were also included. It seems my Perl >> has >> become a bit rusty so I hope the changes make sense. The produced files are >> identical with these patches applied, they are merely doing cleaning as >> opposed >> to bugfixing. >> >> The attached patches are against the 0001-0006 patches from Heikki and you in >> this series of emails, the separation is intended to make them easier to >> read. > > Cool. See also here: > https://www.postgresql.org/message-id/55E52225.4040305%40gmx.net
Nice, not having hacked much Perl in quite a while I had all but forgotten about perlcritic. Running it on the current version of the patchset yields mostly warnings on string values used in the require “convutils.pm” statement. There were however two more interesting reports: one more open() call not using the three parameter form and an instance of map which alters the input value. The latter is not causing an issue since we don’t use the input list past the map but fixing it seems like good form. Attached is a patch that addresses the perlcritic reports (running without any special options). cheers ./daniel
fix_perlcritic.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
