Robert Haas <robertmh...@gmail.com> writes:
> On Wed, Nov 23, 2016 at 4:21 AM, Karl O. Pinc <k...@meme.com> wrote:
>> The bool types on the stack in logfile_rotate() are
>> my work. Bools on the stack don't make sense as far
>> as hardware goes, so the compiler's optimizer should change
>> them to int. This patch changes the bools to ints
>> should that be to someone's taste.
> That does not seem like a good idea from here. Even if it buys some
> microscopic speedup, in a place like this it won't matter. It's more
> important that the code be clear, and using an int where you really
> intend a bool isn't an improvement as far as clarity goes.
Not to mention that the "bools on the stack don't make sense" premise
is bogus anyway.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
