On Tue, Dec 20, 2016 at 12:22 PM, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > Robert Haas wrote: >> Implement table partitioning. > > I thought it was odd to use rd_rel->reloftype as a boolean in > ATExecAttachPartition, but apparently we do it elsewhere too, so let's > leave that complaint for another day.
Ugh. I agree - that's bad style. > What I also found off in the same function is that we use > SearchSysCacheCopyAttName() on each attribute and then don't free the > result, and don't ever use the returned tuple either. A simple fix, I > thought, just remove the "Copy" and add a ReleaseSysCache(). Or use SearchSysCachExists. > But then I > noticed this whole thing is rather strange -- why not pass a boolean > flag down to CreateInheritance() and from there to > MergeAttributesIntoExisting() to implement the check? That seems less > duplicative. Hmm, that would be another way to do it. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
