On Sat, Feb 4, 2017 at 9:01 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Fri, Feb 3, 2017 at 3:56 AM, Peter Eisentraut > <peter.eisentr...@2ndquadrant.com> wrote: >> On 2/2/17 12:48 AM, Michael Paquier wrote: >>> +#define Query_for_list_of_subscriptions \ >>> +" SELECT pg_catalog.quote_ident(subname) "\ >>> +" FROM pg_catalog.pg_subscription "\ >>> +" WHERE substring(pg_catalog.quote_ident(subname),1,%d)='%s'" >> >> This query should also be qualified by current database. > > Indeed. Here is an updated patch.
With this patch, when normal users type TAB after SUBSCRIPTION, they got "permission denied" error. I don't think that's acceptable. In "CREATE SUBSCRIPTION ... PUBLICATION" and "ALTER SUBSCRIPTION ... SET PUBLICATION" cases, the publication defined in the publisher side should be specified. But, with this patch, the tab-completion for PUBLICATION shows the publications defined in local server (ie, subscriber side in those cases). This might be confusing. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
