On Tue, Feb 7, 2017 at 6:35 AM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 2/6/17 10:54 AM, Fujii Masao wrote: >> Yes, that's an option. And, if we add dbid to pg_stat_subscription, >> I'm tempted to add all the pg_subscription's columns except subconninfo >> into pg_stat_subscription. Since subconninfo may contain security-sensitive >> information, it should be excluded. But it seems useful to expose other >> columns. Then, if we expose all the columns except subconninfo, maybe >> it's better to just revoke subconninfo column on pg_subscription instead of >> all columns. Thought? > > I think previous practice is to provide a view such as pg_subscriptions > that contains all the nonprivileged information.
OK, I think that I see the point you are coming at: pg_stat_get_subscription (or stat tables) should not be used for psql's tab completion. So gathering all things discussed, we have: - No tab completion for publications. - Fix the meta-commands. - Addition of a view pg_subscriptions with all the non-sensitive data. (- Or really extend pg_stat_subscriptions with the database ID and use it for tab completion?) Am I missing something? -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
