On Tue, Feb 14, 2017 at 11:36 AM, Andres Freund <[email protected]> wrote: > On 2017-02-13 20:59:43 +0100, Pavel Stehule wrote: >> Hi >> >> 2017-02-13 6:46 GMT+01:00 Michael Paquier <[email protected]>: >> >> > On Sat, Feb 11, 2017 at 3:03 PM, Pavel Stehule <[email protected]> >> > wrote: >> > > here is new update - check is done before any creating >> > >> > It may be better to do any checks before dropping existing databases >> > as well... It would be as well just simpler to complain with a single >> > error message like "database and template list lengths do not match". >> > >> >> next step
This looks fine to me. > I still fail to see why --use-existing as suggested in > https://www.postgresql.org/message-id/[email protected] > isn't sufficient. Some tests create objects without removing them, meaning that continuous runs would fail with only --use-existing. This patch brings value in such cases. -- Michael -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
