On Tue, Feb 14, 2017 at 12:42 PM, Robert Haas <robertmh...@gmail.com> wrote: > Therefore, I proposed the attached patch, which splits spgxlog.h out > of spgist_private.h, nbtxlog.h out of nbtree.h, gistxlog.h out of > gist_private.h, and ginxlog.h and ginblock.h out of gin_private.h. > These new header files are included by pg_waldump in lieu of the > "private" versions. This solves the immediate problem and I suspect > it will head off future problems as well. > > Thoughts, comments, objections, better ideas?
+1 for the overall move. You may want to name the new headers dedicated to WAL records with _xlog.h as suffix though, like gin_xlog.h instead of ginxlog.h. All the existing RMGRs doing this separation (heap, brin, hash and generic) use this format. The patch looks rather sane to me. --- /dev/null +++ b/src/include/access/nbtxlog.h @@ -0,0 +1,255 @@ +/*------------------------------------------------------------------------- + * + * nbtree.h + * header file for postgres btree xlog routines + * + * Portions Copyright (c) 1996-2017, PostgreSQL Global Development Group + * Portions Copyright (c) 1994, Regents of the University of California + * + * src/include/access/nbxlog.h + * + *------------------------------------------------------------------------- + */ This file name is incorrect, as well as the description. +/*-------------------------------------------------------------------------- + * ginxlog.h + * header file for postgres inverted index xlog implementation. + * + * Copyright (c) 2006-2017, PostgreSQL Global Development Group + * + * src/include/access/gin_private.h + *-------------------------------------------------------------------------- + */ Bip. Error. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers