On Tue, Feb 14, 2017 at 4:44 PM, Tom Lane <t...@sss.pgh.pa.us> wrote:
> Corey Huinker <corey.huin...@gmail.com> writes: > > So moving the conditional stack back into PsqlScanState has some side > > effects: conditional.[ch] have to move to the fe_utils/ dirs, and now > > pgbench, which does not use conditionals, would have to link to them. Is > > that a small price to pay for modularity and easier-to-find code? Or > should > > I just tuck it back into psqlscan_int.[ch]? > > Pardon me for coming in late, but what in the world has this to do with > the lexer's state at all? IOW, I don't think I like either of what you're > suggesting ... > > regards, tom lane > Patch v12 has them separated, if that was more to your liking. The stack state lived in MainLoop() and was passed into HandleSlashCommands with an extra state variable.
