Hi, On 2017-03-14 19:34:12 -0400, Tom Lane wrote: > Andres Freund <and...@anarazel.de> writes: > > [ new patch versions ] > > About to leave, but I had time to read 0003: > > It seems bizarre that you chose to spell the new configure symbol as > HAVE__COMPUTED_GOTO rather than HAVE_COMPUTED_GOTO
I went back-and-forth about this a number of times. We have a bunch of symbols defined with HAVE__ as a prefix (and some with HAVE_GCC__) - and more of the nearby code seems to use __ rather than _. I don't really know why we started doing that, but it's far from new.. Any idea why we introduce __ stuff? > Also, being a neatnik, I would insert both the definition and the > call of that macro between PGAC_C_BUILTIN_UNREACHABLE and > PGAC_C_VA_ARGS, keeping it more or less in alphabetical order. That works for me. Thanks, Andres -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
