On Thu, Mar 16, 2017 at 8:42 PM, Robert Haas <robertmh...@gmail.com> wrote: > Thanks for confirming. Some review comments on v2: > > + if (istate->pagetable) fixed > > Please compare explicitly to InvalidDsaPointer. > > + if (iterator->ptbase) > + ptbase = iterator->ptbase->ptentry; > + if (iterator->ptpages) > + idxpages = iterator->ptpages->index; > + if (iterator->ptchunks) > + idxchunks = iterator->ptchunks->index; > > Similarly. fixed
Also fixed at + if (ptbase) + pg_atomic_init_u32(&ptbase->refcount, 0); > > Dilip, please also provide a proposed commit message describing what > this is fixing. Is it just the TBM_EMPTY case, or is there anything > else? Okay, I have added the commit message in the patch. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
fix_tbm_empty_v3.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
