On 2017-03-21 07:46:47 Haribabu Kommi wrote: >On Tue, Mar 21, 2017 at 3:16 PM, Seki, Eiji <seki.e...@jp.fujitsu.com> wrote: >+/* Use these flags in GetOldestXmin as "flags" */ > >How about some thing like the following. >/* Use the following flags as an input "flags" to GetOldestXmin function */ > > >+/* Ignore vacuum backends (Note: this also ignores analyze with vacuum >backends) */ >+#define PROCARRAY_FLAGS_VACUUM >PROCARRAY_FLAGS_DEFAULT | PROCARRAY_VACUUM_FLAG >+/* Ignore analyze backends (Note: this also ignores vacuum with analyze >backends) */ >+#define PROCARRAY_FLAGS_ANALYZE >PROCARRAY_FLAGS_DEFAULT | PROCARRAY_ANALYZE_FLAG > >Whenever the above flags are passed to the GetOldestXmin() function, >it just verifies whether any one of the flags are set in the backend flags >or not. And also actually the PROC_IN_ANALYZE flag will set when >analyze operation is started and reset at the end. I feel, it is not >required to mention the Note section. > >+/* Ignore vacuum backends and analyze ones */ > >How about changing it as "Ignore both vacuum and analyze backends".
Thank you for your review, again. I think your proposals are better, so I reflected them. -- Regards, Eiji Seki Fujitsu
get_oldest_xmin_with_ignore_flags_v4.patch
Description: get_oldest_xmin_with_ignore_flags_v4.patch
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
