On 22 March 2017 at 03:42, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > > On Wed, Mar 22, 2017 at 1:53 PM, Seki, Eiji <seki.e...@jp.fujitsu.com> > wrote: >> >> >> Thank you for your review, again. >> >> I think your proposals are better, so I reflected them. > > > Thanks for the updated patch. Patch looks good to me. > I marked it as "ready for committer".
Looks good. I'll double check and commit this. > While reviewing this patch, I found that PGXACT->vacuumFlags > variable name needs a rename because with the addition of > PROC_IN_LOGICAL_DECODING flag "vacuumFlags" doesn't > only use it for vacuum operation. I feel this variable can be renamed > as just "flags", but anyway that is a different patch. Good point. Should be an open item. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
