On 03/22/2017 12:10 PM, Stephen Frost wrote: >> Still I agree that we should have tests for both cases. > Perhaps, though if I recall correctly, we've basically had zero calls > for fsync() until this. If we don't feel like we need to test that in > the backend then it seems a bit silly to feel like we need it for > pg_dump's regression coverage. > > That said, perhaps the right answer is to have a couple tests for both > the backend and for pg_dump which do exercise the fsync-enabled paths. > >
+1 cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
