On 05/03/2017 03:21 PM, Andres Freund wrote: > On 2017-05-03 15:14:27 -0400, Andrew Dunstan wrote: >> Can someone please explain to me why we have this in Makefile.global.in? >> (from commit e9c81b60 ) >> >> >> PROVE_FLAGS = >> >> >> ISTM it's unnecessary, and prevents us from using the same named value >> in the environment. I want to be able to use the environment in >> vcregress.pl, and I'd like the Make files to work the same way. > Wouldn't it be better to append the environment to the flags here, > that'd allow us to modify flags from both places? >
The Makefile already has: $(PROVE) $(PG_PROVE_FLAGS) $(PROVE_FLAGS) ... It doesn't set PROVE_FLAGS anywhere. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers