On 05/04/2017 12:50 AM, Stephen Frost wrote: > * Tom Lane (t...@sss.pgh.pa.us) wrote: >> Andrew Dunstan <andrew.duns...@2ndquadrant.com> writes: >>> Can someone please explain to me why we have this in Makefile.global.in? >>> (from commit e9c81b60 ) >>> PROVE_FLAGS = >> Before that commit it was like >> >> PROVE_FLAGS = --verbose > right. > >> which had some value. I agree that now we'd be better off to not >> set it at all, especially since the convention now appears to be that >> automatically-supplied prove options should be set in PG_PROVE_FLAGS. > Good point. > >> I'd suggest that the comment just above be replaced by something like >> >> # User-supplied prove flags can be provided in PROVE_FLAGS. > Works for me. >
Does anyone object to me backpatching this? It seems to me kinda crazy to have --verbose hardcoded on the back branches and not on the dev branch. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
