On 01/06/17 15:25, Tom Lane wrote: > Robert Haas <robertmh...@gmail.com> writes: >> So, are you going to, perhaps, commit this? Or who is picking this up? > >> /me knows precious little about Windows. > > I'm not going to be the one to commit this either, but seems like someone > should. >
The new code does not use any windows specific APIs or anything, it just adds retry logic for reattaching when we do EXEC_BACKEND which seems to be agreed way of solving this. I do have couple of comments about the code though. The new parameter retry_count in PGSharedMemoryReAttach() seems to be only used to decide if to log reattach issues so that we don't spam log when retrying, but this fact is not mentioned anywhere. Also, I am not excited about following coding style: > + if (!pgwin32_ReserveSharedMemoryRegion(pi.hProcess)) > + continue; > + else > + { Amit, if you want to avoid having to add the curly braces for single line while still having else, I'd invert the expression in the if () statement so that true comes first. It's much less ugly to have curly braces part first and the continue statement in the else block IMHO. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers