Hi, On 2017-06-03 04:50:00 +0200, Petr Jelinek wrote: > One thing I don't like is the GetLastLocalTransactionId() that I had to > add because we clear the proc->lxid before we get to AtEOXact_Snapshot() > but I don't have better solution there.
I dislike that quite a bit - how about we instead just change the information we keep in exportedSnapshots? I.e. store a pointer to an struct ExportedSnapshot { char *exportedAs; Snapshot snapshot; } Then we can get rid of that relatively ugly list_length() business too. - Andres -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers