On 26 June 2017 at 10:09, Tom Lane <t...@sss.pgh.pa.us> wrote: > Michael Paquier <michael.paqu...@gmail.com> writes: >> On Mon, Jun 26, 2017 at 10:48 AM, Craig Ringer <cr...@2ndquadrant.com> wrote: >>> $node_standby_1->poll_query_until('postgres', q[SELECT xmin IS NULL >>> from pg_replication_slots WHERE slot_name = '] . $slotname_2 . q[']); > >> +1 for avoiding a sleep call if it is not necessary. Fast platforms >> would always pay a cost on that, and slow platforms would wait 1s (or >> more!) when polling for the result. > >> Could it be possible to remove as well the second sleep(2) call in >> this test please? > > Yes, I'd like to see those fixed sleeps go away too. Want to work > on a concrete patch?
Attached. -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
fix-timing-in-tap-001-stream-rep.pl
Description: Perl program
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers