On 26 June 2017 at 11:06, Michael Paquier <michael.paqu...@gmail.com> wrote:
> As long as we are on it, there is this code block in the test: > my ($xmin, $catalog_xmin) = get_slot_xmins($node_master, $slotname_1); > is($xmin, '', 'non-cascaded slot xmin null with no hs_feedback'); > is($catalog_xmin, '', 'non-cascaded slot xmin null with no hs_feedback'); > > ($xmin, $catalog_xmin) = get_slot_xmins($node_standby_1, $slotname_2); > is($xmin, '', 'cascaded slot xmin null with no hs_feedback'); > is($catalog_xmin, '', 'cascaded slot xmin null with no hs_feedback'); > > This should be more verbose as the 2nd and 4th test should say > "catalog xmin" instead of xmin. Agree, should. Mind posting a revision? > Also, wouldn't it be better to poll as well node_standby_1's > pg_replication_slot on slotname_2? It would really seem better to make > the nullness check conditional in get_slot_xmins instead. Sorry for > changing opinion here. I'm not sure I understand this. -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
