On 29 June 2017 at 07:42, Amit Langote <langote_amit...@lab.ntt.co.jp> wrote: > Hi Amit, > > On 2017/06/28 20:43, Amit Khandekar wrote: >> In attached patch v12 > > The patch no longer applies and fails to compile after the following > commit was made yesterday: > > commit 501ed02cf6f4f60c3357775eb07578aebc912d3a > Author: Andrew Gierth <rhodiumt...@postgresql.org> > Date: Wed Jun 28 18:55:03 2017 +0100 > > Fix transition tables for partition/inheritance.
Thanks for informing Amit. As Thomas mentioned upthread, the above commit already uses a tuple conversion mapping from leaf partition to root partitioned table (mt_transition_tupconv_maps), which serves the same purpose as that of the mapping used in the update-partition-key patch during update tuple routing (mt_resultrel_maps). We need to try to merge these two into a general-purpose mapping array such as mt_leaf_root_maps. I haven't done that in the rebased patch (attached), so currently it has both these mapping fields. For transition tables, this map is per-leaf-partition in case of inserts, whereas it is per-subplan result rel for updates. For update-tuple routing, the mapping is required to be per-subplan. Now, for update-row-movement in presence of transition tables, we would require both per-subplan mapping as well as per-leaf-partition mapping, which can't be done if we have a single mapping field, unless we have some way to identify which of the per-leaf partition mapping elements belong to per-subplan rels. So, it's not immediately possible to merge them.
update-partition-key_v12_rebased.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
