On Wed, Sep 6, 2017 at 11:44 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Alvaro Herrera <alvhe...@alvh.no-ip.org> writes: >> Peter Eisentraut wrote: >>> We also need to have a plan for handling the build farm. Maybe keep the >>> vcregress.pl upgradecheck target as a thin wrapper for the time being? > >> The buildfarm already runs "make check" in src/bin/ when TAP tests are >> enabled, which should be enough to trigger the rewritten test, no? > > I think Peter's on about the Windows case. Not sure how that's handled, > but it's not "make check".
For MSVC, one can use "vcregress.bat upgradecheck". So perhaps we could keep upgradecheck for a short time but make it a noop instead with this patch, and then remove it once buildfarm animals are upgraded to a newer client version? I would prefer seeing a simple removal of upgradecheck at the end, and put all TAP tests for binaries under the bincheck path. This feels more natural. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
