On 13 September 2017 at 10:05, Amit Langote <langote_amit...@lab.ntt.co.jp> wrote: > Coincidentally, I just wrote the patch for canonicalizing stored values, > instead of erroring out. Please see attached if that's what you were > thinking too. >
Looks reasonable to me, if we decide to go this way. One minor review comment -- it isn't really necessary to have the separate new boolean local variables as well as the datum kind variables. Just tracking the datum kind is sufficient and slightly simpler. That would also address a slight worry I have that your coding might result in a compiler warning about the kind variables being used uninitialised with some less intelligent compilers, not smart enough to work out that it can't actually happen. Regards, Dean -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers