On Wed, Sep 20, 2017 at 12:49 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Wed, Sep 20, 2017 at 4:25 AM, Michael Paquier > <michael.paqu...@gmail.com> wrote: >> Also, _hash_init() would need some extra work to >> generate FPWs, but I don't think that it is necessary per its handling >> of a per-record meta data either. So REGBUF_STANDARD could be just >> removed from there, and there is actually no need to patch >> src/backend/access/hash at all. >> > > I think there is no need to remove it. As per discussion above, we > want to keep REGBUF_STANDARD for all metapage initializations for the > matter of consistency and that will be useful for > wal_consistency_checking in which case we anyway need full page image.
Arf, yes. You are indeed right. I misread that you still need that anyway in XLogRecordAssemble. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers