On Thu, Sep 21, 2017 at 05:38:13PM -0400, Tom Lane wrote: > I wrote: > > Noah Misch <n...@leadboat.com> writes: > >> Perhaps it is time to require HAVE_WCSTOMBS and HAVE_TOWLOWER, removing > >> USE_WIDE_UPPER_LOWER? Every buildfarm fossil has both. > > > +1 ... if nothing else, there's the problem that untested code is likely > > to be broken. You just proved it *is* broken, of course, but my point > > is that even if we repaired the immediate damage we could have little > > confidence in it staying fixed.
That would be easy enough to ensure by adding ac_cv_func_towlower=no to some buildfarm animal. But the real-world need for said code is clearly dead and gone. Good riddance. > Meanwhile, I see that Peter has posted a fix for the immediate problem. > I propose that Peter should apply his fix in HEAD and v10, and then > I'll rip out the !USE_WIDE_UPPER_LOWER code paths in HEAD only. That works for me. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
