On Sun, Sep 24, 2017 at 5:04 AM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 9/22/17 12:25, Peter Geoghegan wrote: >> On Fri, Sep 22, 2017 at 7:25 AM, Peter Eisentraut >> <peter.eisentr...@2ndquadrant.com> wrote: >>> I agree. The attached patch should do it. >> >> I see one small issue here: You'll now need to set ssup->comparator >> back to NULL before you return early in the Windows' libc case. That >> way, a shim comparator (that goes through bttextcmp(), in the case of >> text) will be installed within FinishSortSupportFunction(). Other than >> that, looks good to me. > > committed accordingly
Thanks. I am currently working on a patch for the issues with ICU colcollate stability as I see them. I should be able to post something later today or tomorrow. I would appreciate it if you held off on committing anything there until you've considered what I'll propose. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
