On Wed, 26 Apr 2006, Teodor Sigaev wrote:
>
> We (me and Oleg) are glad to present GIN to PostgreSQL. If community will
> agree, we will commit it to HEAD branch.
>
> http://www.sigaev.ru/gin/gin.gz
> http://www.sigaev.ru/gin/README.txt
>
> Install:
> % cd pgsql
> % zcat gin.gz | patch -p0
> make and initdb, install tsearch2
I just built this, and noticed that the regression test for "opr_sanity"
fails with your patch. I attached the regression.diffs.
--
BOFH excuse #85:
Windows 95 undocumented "feature"
*** ./expected/opr_sanity.out Wed Jan 25 18:35:51 2006
--- ./results/opr_sanity.out Wed Apr 26 08:31:13 2006
***************
*** 778,785 ****
WHERE p4.amopclaid = p2.oid AND
p4.amopsubtype = p3.amopsubtype);
oid | amname | oid | opcname | amopsubtype
! -----+--------+-----+---------+-------------
! (0 rows)
-- Check that amopopr points at a reasonable-looking operator, ie a binary
-- operator yielding boolean.
--- 778,791 ----
WHERE p4.amopclaid = p2.oid AND
p4.amopsubtype = p3.amopsubtype);
oid | amname | oid | opcname | amopsubtype
! ------+--------+------+-----------+-------------
! 2742 | gin | 2745 | _int4_ops | 0
! 2742 | gin | 2745 | _int4_ops | 0
! 2742 | gin | 2745 | _int4_ops | 0
! 2742 | gin | 2746 | _text_ops | 0
! 2742 | gin | 2746 | _text_ops | 0
! 2742 | gin | 2746 | _text_ops | 0
! (6 rows)
-- Check that amopopr points at a reasonable-looking operator, ie a binary
-- operator yielding boolean.
***************
*** 825,831 ****
783 | 10 | <<|
783 | 11 | |>>
783 | 12 | |&>
! (24 rows)
-- Check that all operators linked to by opclass entries have selectivity
-- estimators. This is not absolutely required, but it seems a reasonable
--- 831,840 ----
783 | 10 | <<|
783 | 11 | |>>
783 | 12 | |&>
! 2742 | 1 | &&
! 2742 | 2 | @
! 2742 | 3 | ~
! (27 rows)
-- Check that all operators linked to by opclass entries have selectivity
-- estimators. This is not absolutely required, but it seems a reasonable
***************
*** 847,854 ****
WHERE p1.amopopr = p2.oid AND p1.amopclaid = p3.oid AND
NOT binary_coercible(p3.opcintype, p2.oprleft);
amopclaid | amopopr | oid | oprname | opcname
! -----------+---------+-----+---------+---------
! (0 rows)
SELECT p1.amopclaid, p1.amopopr, p2.oid, p2.oprname, p3.opcname
FROM pg_amop AS p1, pg_operator AS p2, pg_opclass AS p3
--- 856,869 ----
WHERE p1.amopopr = p2.oid AND p1.amopclaid = p3.oid AND
NOT binary_coercible(p3.opcintype, p2.oprleft);
amopclaid | amopopr | oid | oprname | opcname
! -----------+---------+------+---------+-----------
! 2746 | 2750 | 2750 | && | _text_ops
! 2745 | 2750 | 2750 | && | _int4_ops
! 2746 | 2751 | 2751 | @ | _text_ops
! 2745 | 2751 | 2751 | @ | _int4_ops
! 2746 | 2752 | 2752 | ~ | _text_ops
! 2745 | 2752 | 2752 | ~ | _int4_ops
! (6 rows)
SELECT p1.amopclaid, p1.amopopr, p2.oid, p2.oprname, p3.opcname
FROM pg_amop AS p1, pg_operator AS p2, pg_opclass AS p3
======================================================================
---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings
