Bruce Momjian <pgman@candle.pha.pa.us> writes: > I am thinking it is best to always use E'' in that case. OK?
I'm planning to revert it to the previous logic: E if there's any backslash. I think we have to do likewise in quote_literal() for much the same reason: insufficient confidence that we know how the result will be used. (Note dblink uses quote_literal for strings it will send to the other database.) Currently looking through the rest of the patch. I'm wondering about appendStringLiteral: maybe we should kill that entirely in favor of using PQescapeStringConn? It's not nearly bright enough about encoding for instance (and it *will* be used in client-only encodings). regards, tom lane ---------------------------(end of broadcast)--------------------------- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match