Tom Lane wrote: > I wrote: > > Currently looking through the rest of the patch. I'm wondering > > about appendStringLiteral: maybe we should kill that entirely > > in favor of using PQescapeStringConn? It's not nearly bright > > enough about encoding for instance (and it *will* be used in > > client-only encodings). > > We could make an appendStringLiteralConn, which would do this correctly > for most of the utility programs. However there's a problem for > pg_restore: it doesn't necessarily have a PGconn at all. (Consider > the case of pg_restore producing text output.) > > It seems that the alternatives are to export PQescapeStringInternal > from libpq, or to duplicate its functionality in appendStringLiteral. > Don't much like either, but perhaps the second is less bad. Any > opinions?
I like the export idea myself. The less duplicate code the better. -- Bruce Momjian http://candle.pha.pa.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---------------------------(end of broadcast)--------------------------- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
