When building with MingW, we get a ton of warnings of the type:
C:/Perl/lib/CORE/config.h:39:20: warning: "/*" within comment

(see
http://pgbuildfarm.org/cgi-bin/show_stage_log.pl?nm=vaquita&dt=2007-07-23%20200011&stg=make)

Attached patch removes this by disabling the warning specifically for
plperl on mingw.

Any objections? If not, I'll go ahead and apply...

//Magnus

? src/pl/plperl/SPI.c
? src/pl/plperl/libplperl.so.0.0
Index: src/pl/plperl/GNUmakefile
===================================================================
RCS file: /cvsroot/pgsql/src/pl/plperl/GNUmakefile,v
retrieving revision 1.30
diff -c -r1.30 GNUmakefile
*** src/pl/plperl/GNUmakefile   10 Feb 2007 04:26:24 -0000      1.30
--- src/pl/plperl/GNUmakefile   24 Jul 2007 11:02:13 -0000
***************
*** 21,26 ****
--- 21,29 ----
  perl_privlibexp := $(subst \,/,$(perl_privlibexp))
  perl_embed_ldflags = -L$(perl_archlibexp)/CORE -lperl58
  override CPPFLAGS += -DPLPERL_HAVE_UID_GID
+ # Perl on win32 contains /* within comment all over the header file,
+ # so disable this warning.
+ override CFLAGS += -Wno-comment
  endif
  
  override CPPFLAGS := -I$(srcdir) $(CPPFLAGS) -I$(perl_archlibexp)/CORE
---------------------------(end of broadcast)---------------------------
TIP 7: You can help support the PostgreSQL project by donating at

                http://www.postgresql.org/about/donate

Reply via email to