Magnus Hagander wrote:
On Tue, Jul 24, 2007 at 09:55:57AM -0400, Tom Lane wrote:
Magnus Hagander <[EMAIL PROTECTED]> writes:
  override CPPFLAGS += -DPLPERL_HAVE_UID_GID
+ # Perl on win32 contains /* within comment all over the header file,
+ # so disable this warning.
+ override CFLAGS += -Wno-comment
  endif
If you insist you can apply that in some way that makes it Windows-only.
I object strongly to the patch in this form, because it will mask our
own mistakes as well as one particular Perl build's mistakes.

Uh, it's already inside a win32-only block. So it'll only affect mingw.

Do you know of a way to do it from inside gcc, like the #pragma that exists
for win32 to disable specific warnings? If so we could just disable it on
the line before we #include the perl header, and re-enable it after...


An alternative might be to provide a perl script in the tools directory which would fix the perl header file.

cheers

andrew

---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

              http://www.postgresql.org/docs/faq

Reply via email to