It looks good; would be nice to have something like "git blame" to find out why the line was added.
Also even though this was morphic issue, perhaps we should start adding tests for spec since there are none. :( Peter On Sat, Mar 21, 2015 at 8:19 PM, Johan Fabry <jfa...@dcc.uchile.cl> wrote: > Hi all, > > I am assuming that I am not the only one that gets very annoyed when a > TextMorph scrolls the text when typing, such that the line I am typing is > always at the bottom, or scrolls the debugger when I am stepping over > instructions. I looked into this (bug > > https://pharo.fogbugz.com/f/cases/12569/TextModel-should-not-move-scroll-when-accepting-text > actually) and I found a fix. > > But first I want to understand why the code is as it is. Anybody have any > idea why PluggableTextMorph>>setTextBasic: starts with scrollBar setValue: > 0.0. ?? If I remove this line the very annoying behavior is gone, and as > far as I can see there are no negative consequences on text handling (and > scrolling) in general. So I am wondering why it is there at all. > > A slice with my fix is in the inbox if you want to play a bit with it: > SLICE-Issue-12569-TextModel-should-not-move-scroll-when-accepting-text-johanfabry.1 > > Please have a look, this behavior has been getting on my nerves for quite > some time now … > > > ---> Save our in-boxes! http://emailcharter.org <--- > > Johan Fabry - http://pleiad.cl/~jfabry > PLEIAD lab - Computer Science Department (DCC) - University of Chile > > >
