2016-03-30 19:54 GMT+02:00 Aliaksei Syrel <alex.sy...@gmail.com>: > Do anyone really use GLM-Morphic-Brick? > We all "use" it, our tools are build with this. (inspector/debugger/playground/spotter).
> Because it is there just for spotter and will be deleted ASAP. > Not only for spotter. And if our tools are build with this, people may try to use this for their own tools. This is the core image, and the core tools. What should we say? Please don't use it, but our core tools are built on this? > We know that it is bad. Normal fix requires too many changes... > No excuse. > On Mar 30, 2016 1:34 PM, "Nicolai Hess" <nicolaih...@gmail.com> wrote: > >> Please don't do this: >> >> updateHeight >> "no need to care about height, when it's logic is not customized" >> self layout isHeightCustom ifFalse: [ ^ self ]. >> [ self bounds: (self brickBounds withHeight: self customHeight) ] >> on: Exception >> do: [ "just skip and do nothing" ] >> >> This makes debugging GLM/Brick ui/layout code with "self haltOnce" >> impossible. >> see >> GLMBrickGeometryTrait>>#updateHeight >> GLMBrickGeometryTrait>>#updateWidth >> >> And if you log out the raised exception, you see some calls to >> not initialized fonts and a ZeroDevide and some more errors. >> The above catch, catches and hides wrong / to late initialized objects. >> >
