Au contraire - when looking at a Test - seeing inline the comment of the class to remind me what I’m supposed to be testing is actually quite helpful. I fully expect this is where GtDocumentor is going to take us (if we integrate it into our tools) - letting us inline things so we don’t have to go and hunt them out.
> On 3 Jul 2018, at 22:32, Norbert Hartl <norb...@hartl.name> wrote: > > > > Am 03.07.2018 um 22:40 schrieb Tim Mackinnon <tim@testit.works > <mailto:tim@testit.works>>: > >> And/Or we could display some automatic comment text (unless some is >> provided). >> >> Somethings like >> >> Tests for Xxx >> >> (Xxx comment eg I am class that provides services....) >> > Another example of counter productivity! > > Norbert >> >> >> >> >> Sent from my iPhone >> >> On 3 Jul 2018, at 20:21, Gabriel Cotelli <g.cote...@gmail.com >> <mailto:g.cote...@gmail.com>> wrote: >> >>> Hi, >>> I think that for TestCase subclasses 90% of the time the comment end up in >>> "Unit test of blablabl". Maybe a really complex test case justifies a >>> comment, but it's not the common case. >>> If we can disable the missing comment feedback on TestCase subclasses I >>> will certainly disable it. >>> >>> On Tue, Jul 3, 2018 at 3:48 PM Denis Kudriashov <dionisi...@gmail.com >>> <mailto:dionisi...@gmail.com>> wrote: >>> Hi. >>> >>> I noticed pull requests which add comments to test cases (class comments). >>> I guess the reason is that in Calypso uncommented classes are marked >>> differently than in Nautilus and the exclamation does not disappear when >>> class provides special icon like status of tests. >>> >>> So the question is do we really want people comment test cases? >>> I did not notice any meaningful comment from those PRs. It's like "Unit >>> tests for mirror primitives" for MirrorPrimitiveTests (case 22207 >>> <https://github.com/pharo-project/pharo/pull/1598>). >>> Personally I don't like such approach to put class name with spaces in the >>> comment. It is useless and duplicated. >>> >>> Alternatively I can change uncommented mark to be like in Nautilus. >>> But I like Calypso approach because #systemIcon is not overridden by >>> exclamation. If we want to keep it we need to introduce some >>> #requiresComment to Class which will be overridden by TestCase. >>> >>> So what you think? >>> >>> >>> >>>
