Yes! So I will follow your steps as soon as I have a bit of time. Stef
On Apr 11, 2010, at 11:48 PM, Levente Uzonyi wrote: > On Sun, 11 Apr 2010, Stéphane Ducasse wrote: > >> Hi levente/igor >> >> this hashedCollection is still on my radar. Now I was wondering if I should >> work first on Set with nil or HashedCollection. >> Any idea/suggestion? > > I think it's easier to add HashedCollection first, then the nil support for > Set, because this way you can be sure that the changes added to Set (for the > nil support) won't affect Dictionary. > > > Levente > >> >> Stef >> >> >> On Mar 14, 2010, at 7:02 PM, Levente Uzonyi wrote: >> >>> On Sun, 14 Mar 2010, stephane ducasse wrote: >>> >>>> Hi levente and others >>>> >>>> I always wanted to have Dictionary not be a subclass of Set and you did it. >>>> Now when you introduced that in Squeak, we were busy. >>>> But now I'm so found of this change (like other Smalltalk -> >>>> SmalltalkImage current --- which we stopped in the >>>> middle because lack of momentum and mindsharing) that I would like to >>>> integrate it into Pharo. >>>> Do you have any specific recommandations (like not shooting in our own >>>> foot)? >>> >>> IIRC this is what I did: >>> - created a copy of Set named HashedCollection >>> - changed it's category to Collections-Abstract >>> - changed Set's superclass to HashedCollection while removed it's instance >>> variables >>> - removed Set specific methods from HashedCollection >>> - copied Dictionary specific methods from Set to Dictionary >>> - changed Dictionary's superclass to HashedCollection >>> - removed Dictionary specific methods from Set >>> - cleaup (code that assumes that Dictionary is a Set may be everywhere in >>> the image, for example: Set rehashAllSets won't rehash Dictionaries now, >>> etc) >>> >>> But if you change these classes now, you'll have to update Andrés' changes. >>> That's why I told you earlier to add those changes before touching anything >>> else in the Set hierarchy. The weak dictionary related parts have to be >>> updated already. >>> >>> >>> Levente >>> >>>> >>>> Stef >>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project@lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project@lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project@lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > _______________________________________________ > Pharo-project mailing list > Pharo-project@lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
