Thanks.
May be the windowActiveDropShadowStyle could be just added to the UITheme class?

Open a bug entry and attach code or slice there so that 
        - have a look
        - not forget to integrate the fix.

Stef

> Reduce the complexity of user interface themes
> 
> In general, user interface themes should inherit directly from UITheme, not
> from a chain of themes.  When you have a chain of themes, you are stuck with
> the intermediate themes, whether you need/use them or not.  Consider
> GLMUITheme.  Currently it is under UIThemeWatery2, which is under
> UIThemeWatery, which is under UITheme.
> 
> Some characteristics inherited from the chain are missing, but in principal,
> GLMUITheme can be moved directly under UITheme with just 3 changes.
> 
> 1. Add an instanceVariable 'windowActiveDropShadowStyle'
> 
> UITheme subclass: #GLMUITheme
>       instanceVariableNames: 'windowActiveDropShadowStyle'
>       classVariableNames: ''
>       poolDictionaries: ''
>       category: 'Glamour-Morphic-Theme'
> 
> 2. Add a class method
> 
> isAbstract
>       "Answer whether the receiver is considered to be abstract."
>       ^false
> 
> 3. Add an instance method
> 
> windowActiveDropShadowStyle: anObject
>       "Set the value of windowActiveDropShadowStyle"
>       windowActiveDropShadowStyle := anObject
> 
> 
> Because GLMOrangeUITheme inherits these changes, it does not need
> modification.  
> 
> 
> --
> View this message in context: 
> http://forum.world.st/A-step-toward-reducing-complexity-tp3404504p3404504.html
> Sent from the Pharo Smalltalk mailing list archive at Nabble.com.
> 


Reply via email to