n Wed, Nov 13, 2002 at 10:48:25AM +0100, Marcus Börger wrote: > Normally we discuss this and come to a conclusion before we do such > things here. I did such a thing once myself and wow that was NOT good! > > The votings so far: > > enabled: Wez, Marcus, Maxim, Rui, Moriyoshi, Yasuo > not enabled Jani, Derick, Ilia, Mike, James > The following didn't make their meaning clear: Dan, Andrei, Thies
though i think mbstring is a very usefull thing (for non 8bit system) i *personally* won't need it in the near future. so im +1 on disabling it by default. also i'd like to add a new sidenode: as mbstring changes the size of executor_globals it *might* make binary modules incompatibe between php binaries with mbstring to php compiled without mbstring. i might be wrong, but would it hurt if mbstring: - had it's own globals and zend/php: - had all the hooks to make mbstring loadable as a "normal" php-extension? re, tc > > marcus > > At 05:36 13.11.2002, Andrei Zmievski wrote: > >andrei Tue Nov 12 23:36:04 2002 EDT > > > > Modified files: > > /php4/ext/mbstring config.m4 > > Log: > > Disable mbstring by default. > > > > > >Index: php4/ext/mbstring/config.m4 > >diff -u php4/ext/mbstring/config.m4:1.27 > >php4/ext/mbstring/config.m4:1.28 > >--- php4/ext/mbstring/config.m4:1.27 Thu Oct 10 12:57:52 2002 > >+++ php4/ext/mbstring/config.m4 Tue Nov 12 23:36:04 2002 > >@@ -1,9 +1,9 @@ > > dnl > >-dnl $Id: config.m4,v 1.27 2002/10/10 16:57:52 moriyoshi Exp $ > >+dnl $Id: config.m4,v 1.28 2002/11/13 04:36:04 andrei Exp $ > > dnl > > > > PHP_ARG_ENABLE(mbstring, whether to enable multibyte string support, > >-[ --disable-mbstring Disable multibyte string support], yes) > >+[ --enable-mbstring Enable multibyte string support]) > > > > if test "$PHP_MBSTRING" != "no"; then > > AC_DEFINE(HAVE_MBSTRING,1,[whether to have multibyte string > > support]) > >@@ -36,7 +36,7 @@ > > > > > > PHP_ARG_ENABLE(mbregex, whether to enable multibyte regex support, > >-[ --disable-mbregex Disable multibyte regex support], yes, no) > >+[ --enable-mbregex Enable multibyte regex support], no, no) > > > > if test "$PHP_MBREGEX" != "no" ; then > > AC_DEFINE(HAVE_MBREGEX, 1, [whether to have multibyte regex > > support]) > > > > > > > >-- > >PHP CVS Mailing List (http://www.php.net/) > >To unsubscribe, visit: http://www.php.net/unsub.php > > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php -- Thies C. Arntzen - Looking for all sorts of freelance work - just ask.. http://www.amazon.de/exec/obidos/wishlist/AB9DY62QWDSZ -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php