On Wed, 19 Feb 2003, Corne' Cornelius wrote:
> nobbie Wed Feb 19 04:29:26 2003 EDT
>
> Modified files:
> /php4/ext/informix ifx.ec
> Log:
> - Added Input Descriptor Binding to be used by blobs. This fixed a bug
> where ESQL/C would cause a Segmentation fault if the first blob in a
> result is NULL or '' as soon as it gets a result with blob != NULL
> - Fixed leaks where blobs resources weren't always freed
A few comments:
@@ -116,7 +122,7 @@
{ \
if (ifx_check() < 0) { \
IFXG(sv_sqlcode) = SQLCODE; \
- php_error_docref(NULL TSRMLS_CC, E_WARNING, "Set connection %s fails
(%s)", ifx, ifx_error(ifx)); \
+ php_error(E_WARNING, "%s(): Set connection %s fails (%s)",
+get_active_function_name(TSRMLS_C), ifx, ifx_error(ifx)); \
RETURN_FALSE; \
} \
}
Always use the php_error_docref for new code.
And why did you revert the patch that made it use zend_parse_params
instead of the ugly stuff that is in now? AFACS you used an older
version of the module, and thus revert several patches (including
fixes). Please go over the code again very carefully. I think it would
be best to revert your latest patch and start adding your fixes again.
regards,
Derick
--
Stop mad cowboy disease!
-------------------------------------------------------------------------
Derick Rethans http://derickrethans.nl/
PHP Magazine - PHP Magazine for Professionals http://php-mag.net/
-------------------------------------------------------------------------
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
