Re: [PHP-CVS] cvs: php4 /ext/informix ifx.ec

[Corne' Cornelius]

Hi,

The version i changed on was 1.69, the latest was 1.78. I did a

'cvs update'

and it showed

'M ext/informix/ifx.ec'

but it doens't seem to have merged my file with the latest one. Any ideas why ?
how can i revert it ?

Sorry, CVS newbie (used to RCS)


Derick Rethans wrote:

On Wed, 19 Feb 2003, Corne' Cornelius wrote:

nobbie Wed Feb 19 04:29:26 2003 EDT

Modified files: /php4/ext/informix ifx.ec Log:
- Added Input Descriptor Binding to be used by blobs. This fixed a bug where ESQL/C would cause a Segmentation fault if the first blob in a result is NULL or '' as soon as it gets a result with blob != NULL
- Fixed leaks where blobs resources weren't always freed

A few comments:

@@ -116,7 +122,7 @@
{ \
if (ifx_check() < 0) { \
IFXG(sv_sqlcode) = SQLCODE; \
- php_error_docref(NULL TSRMLS_CC, E_WARNING, "Set connection %s fails (%s)", ifx, ifx_error(ifx)); \
+ php_error(E_WARNING, "%s(): Set connection %s fails (%s)", get_active_function_name(TSRMLS_C), ifx, ifx_error(ifx)); \
RETURN_FALSE; \
} \
}
Always use the php_error_docref for new code.

And why did you revert the patch that made it use zend_parse_params instead of the ugly stuff that is in now? AFACS you used an older version of the module, and thus revert several patches (including fixes). Please go over the code again very carefully. I think it would be best to revert your latest patch and start adding your fixes again.

regards,
Derick

=============Disclaimer and Confidentiality===================
This message contains information intended for the perusal, and/or use (if so stated), by the stated addressee(s) only. The information is confidential and privileged. If you are not an intended recipient, do not peruse, use, disseminate, distribute, copy or in any manner rely upon  he information contained in this message (directly or indirectly). The sender and/or the entity represented by the sender shall not be held accountable in the event that this prohibition is disregarded. If you receive this message in error, notify the sender immediately by e-mail, fax or telephone representations contained in this message, whether express or implied, are those of the sender only, unless that sender expressly states them to be the views or representations of an entity or person, who shall be named by the sender and who the sender shall state to represent. No liability shall otherwise attach to any other entity or person. ======================================================