Btw, any reason why we need all those redefinition of functions? If it's just to save having to write TSRMLS_C then I'd prefer to remove those macros. They just make debugging harder, there's no real benefit and we've tried to be explicit in other places. The patch looks nice though although I haven't finished reading through the whole thing (I also just found some of the explanations :)Thanks.

+#define php_output_clean() _php_output_clean(TSRMLS_C)
+PHPAPI int _php_output_clean(TSRMLS_D);
+
+#define php_output_clean_all() _php_output_clean_all(TSRMLS_C)
+PHPAPI void _php_output_clean_all(TSRMLS_D);
+
+#define php_output_end() _php_output_end(TSRMLS_C)
+PHPAPI int _php_output_end(TSRMLS_D);
+
+#define php_output_end_all() _php_output_end_all(TSRMLS_C)
+PHPAPI void _php_output_end_all(TSRMLS_D);
+
+#define php_output_discard() _php_output_discard(TSRMLS_C)
+PHPAPI int _php_output_discard(TSRMLS_D);
+
+#define php_output_discard_all() _php_output_discard_all(TSRMLS_C)
+PHPAPI void _php_output_discard_all(TSRMLS_D);


At 12:51 PM 6/2/2006, Michael Wallner wrote:
mike            Fri Jun  2 19:51:43 2006 UTC

  Added files:
    /php-src    README.NEW-OUTPUT-API
    /php-src/tests/output       .cvsignore ob_001.phpt ob_002.phpt
                                ob_003.phpt ob_004.phpt ob_005.phpt
                                ob_006.phpt ob_007.phpt ob_008.phpt
                                ob_009.phpt ob_010.phpt ob_011.phpt
                                ob_012.phpt ob_013.phpt ob_014.phpt
                                ob_015.phpt

  Modified files:
    /php-src/ext/pgsql  pgsql.c
    /php-src/ext/session        session.c
    /php-src/ext/soap   soap.c
    /php-src/ext/standard       basic_functions.c head.c info.c
                                url_scanner_ex.c url_scanner_ex.re var.c
    /php-src/ext/tidy   tidy.c
    /php-src/ext/zlib   php_zlib.h zlib.c
    /php-src/main       SAPI.c main.c output.c php.h php_output.h
    /php-src/sapi/apache        mod_php5.c php_apache.c
    /php-src/sapi/apache2handler        php_functions.c
    /php-src/sapi/apache_hooks  mod_php5.c php_apache.c
    /php-src/sapi/cgi   cgi_main.c
    /php-src/sapi/cli   php_cli.c
    /php-src/sapi/milter        php_milter.c
    /php-src/sapi/nsapi nsapi.c
  Log:
  - new output control code

  # scan README.NEW-OUTPUT-API to get a grasp
  # tree has been tagged with BEFORE_NEW_OUTPUT_API
  #
  # TODO:
  #  - improve existing output handlers
  #  - move zlib.output_compression cruft from SAPI.c to zlib.c
  #  - output_encoding handling was ambigious, resp. is undefined yet
  #  - more tests



--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to