On 03.06.2006 00:56, Andi Gutmans wrote:
Btw, any reason why we need all those redefinition of functions? If it's just to save having to write TSRMLS_C then I'd prefer to remove those macros. They just make debugging harder

I have to second that - those macros basically add even more confusion during 
debugging.
I bet you should know how annoying are similar macros in streams API.


, there's no real benefit and we've tried to be explicit in other places. The patch looks nice though although I haven't finished reading through the whole thing (I also just found some of the explanations :)Thanks.

+#define php_output_clean() _php_output_clean(TSRMLS_C)
+PHPAPI int _php_output_clean(TSRMLS_D);
+
+#define php_output_clean_all() _php_output_clean_all(TSRMLS_C)
+PHPAPI void _php_output_clean_all(TSRMLS_D);
+
+#define php_output_end() _php_output_end(TSRMLS_C)
+PHPAPI int _php_output_end(TSRMLS_D);
+
+#define php_output_end_all() _php_output_end_all(TSRMLS_C)
+PHPAPI void _php_output_end_all(TSRMLS_D);
+
+#define php_output_discard() _php_output_discard(TSRMLS_C)
+PHPAPI int _php_output_discard(TSRMLS_D);
+
+#define php_output_discard_all() _php_output_discard_all(TSRMLS_C)
+PHPAPI void _php_output_discard_all(TSRMLS_D);


--
Wbr, Antony Dovgal

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to