Here are comments regarding each commit.
http://news.php.net/article.php?group=php.cvs&article=9700
I've restored the old behaviour regarding SID (#15322).
A reordering of estrdups has also been committed. I suppose
the message "fix small memory leak" refers to that.
These estrdup-related patches were flawed, because they did
not take into account that some values are overwritten during
the execution of the function. So, the estrdup has to occur
earlier.
http://news.php.net/article.php?group=php.cvs&article=9701
Rejected semantical change.
http://news.php.net/article.php?group=php.cvs&article=9703
TSRM API changes, reapplied. The patch was mixed with
anti-mem leak and semantical changes. Those were left out.
http://news.php.net/article.php?group=php.cvs&article=9705
Good.
http://news.php.net/article.php?group=php.cvs&article=9706
Flawed and related to the rejected semantical change
regarding the decode process.
http://news.php.net/article.php?group=php.cvs&article=9707
Does not make sense to me and needs to be discussed further.
Why should we prevent users from changing the session module?
http://news.php.net/article.php?group=php.cvs&article=9708
Should be reapplied.
http://news.php.net/article.php?group=php.cvs&article=9709
Why was rinit_mod = 1 removed? (added in 9707)
http://news.php.net/article.php?group=php.cvs&article=9712
Does not make sense. Die, if session module cannot be
initialized.
http://news.php.net/article.php?group=php.cvs&article=9714
Rejected. data->fd is already set by ps_files_close().
I fail to see how this is related to a segfault in the output
buffering section as discussed in #14232?
http://news.php.net/article.php?group=php.cvs&article=9715
Imposing filenames does not make sense. Rejected.
- Sascha Experience IRCG
http://schumann.cx/ http://schumann.cx/ircg
--
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php