> I'll check and update doc if needed.
That was a direct quote from the documentation.
> > No. Try to read the code again. A user handler should
> > simply return a non-string.
>
> It works sometimes, but it segfaults sometimes. (with original code)
..then please send me a test case.
> > A php function can itself halt the script execution, so there
> > is no need to enforce bailing out.
>
> It's not my point.
> Current code is not obvious that session save handler does not
> write bogus session data when read is failed with other errors
> like network and database.
If something is not obvious, document it.
> Of couse, we can do that.
> We just have to type more.
Does not emacs have some sort of completion for that?
> AFAIK, session module has 2 bugs due to this design.
> I suggest to use one single status to indicate current session
> module's status.
That sounds useful.
> > Then the user should either set save_handler to "user" or
> > not change it all (files is perfectly happy then).
>
> files are happy, since it shares save_path. What about
> others?
If the user has access to php.ini and wants to use a custom
save_handler, he should not temper with the save_handler
settings.
> Then static path?
I need to look into that.
> If we can decide 100% error and should never allow that,
> yes. But it's not the case for mm start up.
I think this case is irrelevant.
> I was spending my time to fix sevral serious sessoin module
> bugs, but it seems we have a lot different opinion for
> coding style.
>
> I'll just keep my own session module bug free for my usage.
> (I leave session module as is. Fix other bugs)
I'd appreciate it, if you could share your wisdom by making
your test cases available to the public.
- Sascha Experience IRCG
http://schumann.cx/ http://schumann.cx/ircg
--
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php
