Hi Marcus, Just 2 points:
In your update to this patch, you have a fixme for the case where get_active_function_name(TSRMLS_C) returns NULL. AFAICT, this will only happen in rare circumstances and doesn't have anything to do with the build being a TSRM build or not. So it's a bit of a misleading comment, that's all :-) Secondly, I think it makes sense to have the function check for a # and manipulate the string (taking into account the file extension setting) so that we can refer to a specific part of a page: Eg: When the extension is .html: foo#bar --> http://mydocs/php/foo.html#bar foo --> http://mydocs/php/foo.html When the extension is .php foo#bar --> http://mydocs/php/foo.php#bar foo --> http://mydocs/php/foo.php On the whole, good work! <feelingguiltyfornotcontributingrecently> I'm itching to review the streams code ready for the upcoming release, but I'm still too busy for the next couple of weeks - and then I can take a break from all this hard work! </feelingguiltyfornotcontributingrecently> --Wez. On 08/08/02, "Marcus Börger" <[EMAIL PROTECTED]> wrote: > First thanks to Wez for another great idea. And it's not really my idea :-) It's some anonymous persons idea (checking the cvs log for the todo will reveal who!). -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php
