At 22:35 08.08.2002, Wez Furlong wrote:
>Hi Marcus,
>
>Just 2 points:
>
>In your update to this patch, you have a fixme for the case where
>get_active_function_name(TSRMLS_C) returns NULL. AFAICT, this will
>only happen in rare circumstances and doesn't have anything to do
>with the build being a TSRM build or not. So it's a bit of a misleading
>comment, that's all :-)
Yes the TSRM part should be removed there. And in case of NULL
from get_active_functionname we can say "Unknown" but do not generate
a reference.
>Secondly, I think it makes sense to have the function check for a #
>and manipulate the string (taking into account the file extension setting)
>so that we can refer to a specific part of a page:
I thought about this, too. But it seemed to complex....(to implement).
The main problem is the dot in function references ("function" "." <name>).
If we could insist for the docref parameter not to contain any extension
we could simply insert before any '#' or add in case of absense of '#'.
marcus
>Eg:
> When the extension is .html:
> foo#bar --> http://mydocs/php/foo.html#bar
> foo --> http://mydocs/php/foo.html
> When the extension is .php
> foo#bar --> http://mydocs/php/foo.php#bar
> foo --> http://mydocs/php/foo.php
>
>On the whole, good work!
>
><feelingguiltyfornotcontributingrecently>
>I'm itching to review the streams code ready for the upcoming release,
>but I'm still too busy for the next couple of weeks - and then I can
>take a break from all this hard work!
></feelingguiltyfornotcontributingrecently>
>
>--Wez.
>
>On 08/08/02, "Marcus Börger" <[EMAIL PROTECTED]> wrote:
> > First thanks to Wez for another great idea.
>
>And it's not really my idea :-)
>It's some anonymous persons idea (checking the cvs log for the
>todo will reveal who!).
>
>
>
>--
>PHP Development Mailing List <http://www.php.net/>
>To unsubscribe, visit: http://www.php.net/unsub.php
--
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php
